Skip to content

Some minor formatting proposals around folders#845

Merged
cheenamalhotra merged 1 commit intomicrosoft:devfrom
kant:patch-2
Oct 24, 2018
Merged

Some minor formatting proposals around folders#845
cheenamalhotra merged 1 commit intomicrosoft:devfrom
kant:patch-2

Conversation

@kant
Copy link
Contributor

@kant kant commented Oct 23, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 23, 2018 •
edited
Loading

Codecov Report

Merging #845 into dev will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #845      +/-   ##
============================================
+ Coverage     48.29%   48.62%   +0.33%     
- Complexity     2781     2810      +29     
============================================
  Files           116      116              
  Lines         27877    27877              
  Branches       4651     4651              
============================================
+ Hits          13462    13555      +93     
+ Misses        12200    12190      -10     
+ Partials       2215     2132      -83
Flag Coverage Δ Complexity Δ
#JDBC42 47.79% <ø> (-0.02%) 2736 <ø> (-4)
#JDBC43 48.55% <ø> (+0.32%) 2807 <ø> (+28) ⬆️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-3.3%) 15% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.57% <0%> (-0.2%) 255% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.34% <0%> (ø) 262% <0%> (+1%) ⬆️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.63% <0%> (+0.21%) 92% <0%> (+2%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.8% <0%> (+0.28%) 141% <0%> (+6%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.34% <0%> (+0.34%) 0% <0%> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.45% <0%> (+0.53%) 349% <0%> (+15%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 68.96% <0%> (+0.86%) 0% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39.22% <0%> (+1.07%) 44% <0%> (+2%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.29% <0%> (+1.09%) 107% <0%> (+1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5167636...55def75. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.2 milestone Oct 23, 2018
@cheenamalhotra cheenamalhotra merged commit 538863b into microsoft:dev Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+1 more reviewer

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.1.2

Development

Successfully merging this pull request may close these issues.

4 participants

@kant @codecov-io @cheenamalhotra @peterbae